search

SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.
https://srgssr.github.io/pillarbox-web-demo/
MIT License
12 stars 1 forks source link

fix(media-composition): remove audio chapters #247

Closed amtins closed 5 months ago

amtins commented 5 months ago

Description

Fixes #245 by removing audio chapters from mediaComposition. The reason for this is that audio chaptering is physical, not logical. This results in data inconsistency and prevents chapter change events from being sent.

Ref: https://github.com/SRGSSR/pillarbox-apple/pull/842

Changes made

github-actions[bot] commented 5 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-04-24 14:33 UTC

github-actions[bot] commented 5 months ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟢 Statements
98.72% (+0.01% 🔼)
 617/625
🟢 Branches
95.74% (+0.03% 🔼)
 292/305
🟢 Functions
99.43% (+0% 🔼)
 173/174
🟢 Lines
99.15% (+0% 🔼)
 581/586

Test suite run success

199 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from ab870a087ef69aa17a8757b3c18a9c51ce789af4

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 1.11.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: