SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.
http://web.pillarbox.ch/api
MIT License
15 stars 1 forks source link

fix(analytics): use new textrack API #53

Closed jboix closed 1 year ago

jboix commented 1 year ago

Description

Closes #52

The SRGAnalytics class was still using the videojs textTracks.

Changes made

This fix substitutes it for the newly introduced textTrack which already filters the subtitles by show status and excludes any subtitle labelled as metadata or chapter.

github-actions[bot] commented 1 year ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements
98.35% (-0.21% πŸ”»)
476/484
🟒 Branches
93.42% (-0.41% πŸ”»)
227/243
🟒 Functions 100% 137/137
🟒 Lines
99.14% (-0.22% πŸ”»)
459/463
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------- | :------------------------------------------------------------- | :------------------------------------------------------------- | :-------- | :------------------------------------------------------------- | | 🟒 |
`...` / SRGAnalytics.js
|
97.49% (-0.44% πŸ”»)
|
90.16% (-0.82% πŸ”»)
| 100% |
98.29% (-0.44% πŸ”»)
|

Test suite run success

142 tests passing in 9 suites.

Report generated by πŸ§ͺjest coverage report action from fd72f190796135b9c86fe56871d902287b8bcdf5

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: