search

SRGSSR / playsrg-apple

The Play SRG applications for iOS and tvOS
https://srgssr.github.io/playsrg-apple/
MIT License
44 stars 3 forks source link

Incorrect Google Cast behavior with downloaded content #111

Open defagos opened 5 years ago

defagos commented 5 years ago

The Google Cast player is not displayed (the usual player is instead) when Google Casting a downloaded media. The media is not played on the receiver.

Issue type

Incorrect behavior

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Open Play SRG and download an audio media.
  2. After the media has been fully downloaded, open it and play it on a Google Cast receiver.
  3. Instead of the Google Cast player being displayed, the original player is is presented, and media playback continues locally. No playback resumes on the Google Cast receiver.
defagos commented 5 years ago

The code to deal with this special case (no media composition, only a media) has simply never been written 🙃

I see two ways of solving this issue:

  1. We implement it properly (but currently most of Google Cast setup code requires a media composition).
  2. We disable Google Cast for downloaded medias (uglier but straightforward to implement).