Improve notification center publishers

SRGSSR / playsrg-apple

The Play SRG applications for iOS and tvOS

https://srgssr.github.io/playsrg-apple/

MIT License

44 stars 3 forks source link

Improve notification center publishers #218

Closed pyby closed 2 years ago

pyby commented 2 years ago

Issue type

Incorrect behavior

Description of the problem

Combine publishers for the notification center must not retain observed object.

@defagos found the issue here: https://github.com/SRGSSR/pillarbox-apple/pull/35

Environment information

Application version: All with swift code
iOS / tvOS version: Any
Device: Any

Reproducibility

Always reproducible with a unit test (see Pillar box PR link above)

pyby commented 2 years ago

Tested in Play iOS nightly 200 and Play tvOS 365.

With Download notifications and updates on iOS, which as subscribed notifications with an object: I didn't see regressions. It helped to discover #220 .