iOS 17 / tvOS 17 compatibility

SRGSSR / playsrg-apple

The Play SRG applications for iOS and tvOS

https://srgssr.github.io/playsrg-apple/

MIT License

44 stars 3 forks source link

iOS 17 / tvOS 17 compatibility #336

Closed pyby closed 1 year ago

pyby commented 1 year ago

Issue type

As usual we must work on compatibility updates for iOS 17 and tvOS 17.

Description of the problem

Build and check all features, UI and UX work as expected.

List of tasks:

[x] Update AppCenter to fix build: https://github.com/microsoft/appcenter-sdk-apple/issues/2484
[x] Update AirShip to fix build: https://github.com/urbanairship/ios-library/issues/362
[x] Fix iOS page layout issue when switching between apps. https://github.com/SRGSSR/playsrg-apple/pull/366
[x] Fix tvOS Settings page layout issue with focused zoom button.
[x] Fix tvOS Settings page layout issue when opening a modal.
[x] Fix iOS error message when adding a program to a calendar.

defagos commented 1 year ago

It appears there is a layout issue with collections when building the Play app with the iOS 17 SDK, at least with beta 8:

Open a screen on an iPad (e.g. the home page).
Scroll down a bit so that the her section is cut in half.
Switch to another app (or send the app to the background).
Resume the app. The layout is broken.

Here is a video of the above.

defagos commented 1 year ago

The layout is due to incorrect horizontal layout traits propagation to the collection view layout, most likely due to changes to the traits hierarchy.

Maybe there is also a bug to report to Apple here.

waliid commented 1 year ago

The layout is due to incorrect horizontal layout traits propagation to the collection view layout, most likely due to changes to the traits hierarchy.

Maybe there is also a bug to report to Apple here.

Indeed, prior to iOS 17, a child view controller inherited its trait collection from its parent view controller. Starting from iOS 17, a child view controller inherits its trait collection from its superview.

defagos commented 1 year ago

The collection view issue has been reported as iOS 17 regression: Collection view composition layout environment trait collection is incorrectly updated, filed under FB13173057.

pyby commented 1 year ago

On tvOS 17, the List SwiftUI view used:

"clipped to bounds": focused button layout is clipped leading and trailing.
Not updated label color for focused button when reappearing after presenting an other view controller above.

Here is a video.

defagos commented 1 year ago

The focused button issue is a tvOS 17 regression, reported as tvOS 17 regression: Cell default focused appearance is broken after modal presentation dismissal under FB13183500.

defagos commented 1 year ago

The cell issue appearance FB13183500 has (mostly) been fixed in tvOS 17.1 beta 1. Still it seems that presenting a modal from a SwiftUI button using UIKit presentation has broken behavior.

For the moment I won't close the issue, maybe we should create another sample project with a UIKit modal, report this issue separately and close the above one.