SRGSSR / playsrg-apple

The Play SRG applications for iOS and tvOS

https://srgssr.github.io/playsrg-apple/

MIT License

44 stars 3 forks source link

Use PlaySRG image service #344

Closed pyby closed 1 year ago

pyby commented 1 year ago

Issue type

Feature request

Description

Integration Layer product has deprecated endpoints, which will be removed during migration to the new major version (named SAM): Services to transform images.

In addition:

SRF business unit image service will remove the scaling support in 2023 Q4.
RTS business unit image service does not work as expected with PlaySRG image service, regarding the aspect ratio given within the url. Will be fix in 2023 Q3.

Main new image service to use is the PlaySRG image service.

Environment information

Images are provided by SRGDataProvider.
In Player, SRGLetterbox uses SRGDataProvider as well.
Application version: Any
iOS / tvOS version: Any
Device: Any

pyby commented 1 year ago

Moving all in one time seems to not be doable, regarding dependencies. https://github.com/SRGSSR/srgdataprovider-apple/pull/44

Looks good with urls from:

RSI CMS image service.
RTR/SRF CMS image sercice.
SWI CMS image service.
IL with legacy image service urls (some rules for vectors).

The PlaySRG image services not fit well with:

RTS CMS image service: returns raw image which many various image ratios (06.2023) (Internal Jira ticket).
IL with vector images. imageUrl from SRGChannel and SRGProgram returns blurred scalded image (mid 07.2023) (Internal Jira ticket).

Proposition would be:

to switch all to PlaySRG image services, if it fits with the given image urls.
Keep BU image service and switch later when fixed between it and PlaySRG image service.

pyby commented 1 year ago

Open question: With PlaySRG Service, the image format could be asked.

Here are an example of an SRF audio thumbnail requested:

Service	Image url	content-type	content-length	Usage
BU	https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png/scale/width/320	image/png	133393	Current request
PlaySRG png	https://il.srgssr.ch/images/?imageUrl=https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png&format=png&width=320	image/png	135647	Future request, url is a png
PlaySRG jpg	https://il.srgssr.ch/images/?imageUrl=https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png&format=jpg&width=320	image/jpeg	8174
PlaySRG webp	https://il.srgssr.ch/images/?imageUrl=https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png&format=webp&width=320	image/webp	7718

Asking png only for channel logo or custom button for the UI, and use jpg for all content image?

We should ask designers, if HeroStage images or highlighted images are allowed to be transparence (and work with the page background).

pyby commented 1 year ago

The PlaySRG image services not fit well with:

RTS CMS image service: returns raw image which many various image ratios (06.2023) (Internal Jira ticket).

IL with vector images. imageUrl from SRGChannel and SRGProgram returns blurred scalded image (mid 07.2023) (Internal Jira ticket).

RTS CMS image service is still used instead of using PlaySRG image service, in SRGDataProvider: https://github.com/SRGSSR/srgdataprovider-apple/pull/44
IL with vector images. imageUrl from SRGChannel and SRGProgram. Workaround to get channel rawImageUrl instead: in ProgramViewModel.

pyby commented 1 year ago

The SRGProgram's fallback imageUrl can't be used in Play SRG image service (blurred image). https://github.com/SRGSSR/srgdataprovider-apple/pull/49 ignore those image urls.

352 introduces a fallback on the related channel raw image url.