SRGSSR / playsrg-apple

The Play SRG applications for iOS and tvOS
https://srgssr.github.io/playsrg-apple/
MIT License
44 stars 3 forks source link

PLAYRTS-5590 Update Highlight Cell Design #504

Open mutaben opened 4 months ago

mutaben commented 4 months ago

Description

Up until now, there was a linear gradient on Highlight Cells, helping make the text more legible.

This PR improves this aspect based on UI/UX requirements, by improving legibility without darkening the highlighted content too much.

In the following images, you can see the raw gradients, how they used to be and how they were implemented after various attempts to find the best result.

Please see also some screenshots to see it in action today.




Changes Made

This was implemented by:

The gradients were tweaked for large and compact size, and for different amount of text content. (see the raw gradients above)

If they need to be adjusted in the future, they now have their own view and the midway point to stop the gradient is customizable as a parameter.

Checklist

pradie-charlotte commented 4 months ago

Did you also change highlight's dimensions ? ( mobile 200, tablet portrait 280, and tablet landscape 480) Cause on android tablet (landscape mode), highlight looks a little bit large. Have you got the same impression/ result on ios ? You can see the android tablet landscape result on the android merge request

mutaben commented 4 months ago

Did you also change highlight's dimensions ? ( mobile 200, tablet portrait 280, and tablet landscape 480) Cause on android tablet (landscape mode), highlight looks a little bit large. Have you got the same impression/ result on ios ? You can see the android tablet landscape result on the android merge request

@pradie-charlotte No, we defined only two highlights, one for compact, and one for regular, and I tried to stick to the Figma. Hope that helps.

pyby commented 4 months ago

@pradie-charlotte No, we defined only two highlights, one for compact, and one for regular, and I tried to stick to the Figma. Hope that helps.

@mutaben But if the UX team proposes a third one compatible with Apple rotation and size classes, this iPad may could do this: ShowHeaderView (header) and HeroMediaCell (content cell, like the highlighted one) have three layouts:

If the Android test on tablet is validated, let check on iPad then.

Loic-Dumas commented 4 months ago

Hello @mutaben @pyby , To clarify the current status on Android.

As explained by @pradie-charlotte, we have these height for the highlight, as defined in the Figma:

We Asked Alessandra if for the tablet land 480 was too much. But since she's on holiday, we decided to merge, and update the height later if needed.