search

SRGSSR / playsrg-apple

The Play SRG applications for iOS and tvOS
https://srgssr.github.io/playsrg-apple/
MIT License
44 stars 3 forks source link

Resume playback of a briefly seen segment might resume before its start #90

Open defagos opened 6 years ago

defagos commented 6 years ago

If a segment as been very briefly played, resuming it will efficiently try to seek at the nearest chunk before the position. Currently the start position can be located before the segment. It should not.

Issue type

Incorrect behavior

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Open a segment (e.g. 19h30 subject).
  2. Immediately close it.
  3. Reopen it. If the segment start was not in the direct vicinity of a chunk start, playback will resume before the segment. Otherwise pick another segment.
defagos commented 6 years ago

This is an SRG Media Player issue. I opened a dedicated ticket on its issue tracker.

defagos commented 6 years ago

For the moment, as this is an AVPlayer bug, we decided to put this issue on hold. We could use accurate seeking when resuming playback, but we decided that for the moment this was acceptable as it is now.

I'll update this issue once I have more feedback from Apple.

defagos commented 3 years ago

This issue has been fixed by Apple. We don't use tolerances at the moment because of an issue with RTS content (https://github.com/SRGSSR/srgletterbox-apple/issues/245). We must ensure this issue is fixed as well before we re-enable tolerances again (tolerance before only for resuming playback efficiently). We might also prefer to use precise seeking for resuming playback, in which case this issue can be closed.