Frontend in Node.js failed during installation

SRGSSR / playsrg-playfff

Play Features and Functionalities with Flair, a Play SRG service for Play SRG mobile applications

MIT License

1 stars 0 forks source link

Closed pyby closed 10 months ago

pyby commented 1 year ago

Incorrect behavior

Since 30.04.2023, the CI and Herokuapp can't install the frontend part in Nodejs. The PR https://github.com/SRGSSR/playsrg-playfff/pull/75 can't be deployed.

  Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.6:npm (npm install) on project playfff: Failed to run task

Too old node.js libraries.

Always reproducible

pyby commented 10 months ago

Various strategies exist.

Building a a new frontend with up to date components is one solution.

https://github.com/SRGSSR/playsrg-playfff/tree/76-fix-frontend-build ng serve run locally. On Heroku, we need to understand how the node.js server is started and watched for urls after the /login from Sprint boot.

pyby commented 10 months ago

The updated stack is adapted:

Node.js build distribution is copied to the jar resources.
WebMvcConfigurerAdapter Spring Boot server is mapping static file urls to the web Angular application files.

Those tasks are under code control now.

pyby commented 10 months ago

Adaption required for Android requests:

//api/v2/deeplink/parsePlayUrl.js -> "//".
/api/v2/playlist/recommendation/{purpose}/{urn}", "/api/v2/playlist/recommendation/{purpose}/{urn}.json -> ".json" extension.

The CI needs to run unit test again.

pyby commented 10 months ago

To run mvn clean test, an up to date maven-surefire-plugin configuration needed. Done, the CI runs now 125 tests.