SRGSSR / srgdataprovider-apple

A library to retrieve SRG SSR unified metadata
MIT License
0 stars 1 forks source link

Remove legacy image scaling options #44

Closed pyby closed 1 year ago

pyby commented 1 year ago

Motivation and Context

Integration Layer product has deprecated endpoints, which will be removed during migration to the new major version (named SAM): Services to transform images.

In addition:

The ImageServices has to be updated accordingly.

Main new image service to use is the PlaySRG image service.

Description

Checklist

defagos commented 1 year ago

Before having a more comprehensive look at the code, just a few clarification questions:

  1. Do we still really need to provide access to the /scale/width services? Isn't the new endpoint sufficient?
  2. If yes:
    • Which name could we find so that API usage is easy? I am not sure that just looking at the API makes it easy to know when each kind of service needs to be applied. Previously the intent was clear (scaling behavior) but now this context has disappeared and I am not sure why, as a user, I should use one service rather than the other.
    • Why should the BU scaling service be the default? Shouldn't we move away from it?
pyby commented 1 year ago

Before having a more comprehensive look at the code, just a few clarification questions:

  1. Do we still really need to provide access to the /scale/width services? Isn't the new endpoint sufficient? […]
    • Why should the BU scaling service be the default? Shouldn't we move away from it?

After discussions with RTS colleagues, the RTS image service will support ratio in url in 2023 Q3, not before. The PlaySRG image service keeps the image ratio given by the url, which is today for RTS a "raw" image ratio: unexpected image ratios are returned.

To move on, the new proportion: