Modal transition assertions

SRGSSR / srgidentity-apple

The SRG signup and login framework

MIT License

1 stars 0 forks source link

Closed defagos closed 3 years ago

defagos commented 3 years ago

@oiledCode reported that modal transition asserts when the account view is presented from a sheet modal view (default iOS 13 presentation style).

The code does not crash in release builds, but the work recently done on modals was not applied to SRG Identity. This should be fixed.

Incorrect behavior

Always reproducible

defagos commented 3 years ago

I fixed the issue on the feature/modal-presentation-fix branch:

The modal presentation style is now custom, as should be.
I updated the transition code accordingly.
To ensure the presenting view is correctly animated (i.e. that we have a fromView), I introduced a UIPresentationController subclass to enabled presenting view removal. I updated the transition code to reinstall the view when the modal is dismissed.

defagos commented 3 years ago

As discussed with @oiledCode, the fix is not urgent, as release builds do not crash. Still we should code review it and deliver it in 2021.