search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

Duplicate frameworks issue after Carthage update #156

Closed fredhdroz closed 6 years ago

fredhdroz commented 6 years ago

Issue type

Other: Carthage issue / App Store issue

Description of the problem

After running carthage update, the SRGLetterbox.framework contains a subfolder named "Frameworks" with duplicated frameworks

This cause no issues when running the app, but iTunesConnect refuses to validate the application due to the following errors:

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'org.mantle.Mantle' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'com.comscore.ComScore' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGNetwork' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'com.ibireme.YYWebImage' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'uk.co.charcoaldesign.FXReachability' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGDataProvider' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGMediaPlayer' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'com.mikeash.MAKVONotificationCenter-iOS-framework' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGAppearance' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGLogger' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGMediaPlayerAnalytics' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'TC.TCCore' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'com.ashaman.libextobjc' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'com.cloudling.Masonry' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'TC.TCSDK' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'ch.srgssr.SRGAnalytics' under the iOS application

CFBundleIdentifier Collision - There is more than one bundle with the CFBundleIdentifier value 'SRG.SRGAnalytics-DataProvider' under the iOS application

Invalid Bundle - The bundle at 'RTSSport.app/Frameworks/SRGLetterbox.framework' contains disallowed nested bundles.

Invalid Bundle - The bundle at 'RTSSport.app/Frameworks/SRGLetterbox.framework' contains disallowed file 'Frameworks'.

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Create a new Xcode Project
  2. Add a new Cartfile with : github "SRGSSR/srgletterbox-ios" == 1.10.1
  3. Run Carthage update
  4. Carthage/Build/iOS/SRGLetterbox.framework includes duplicated frameworks
defagos commented 6 years ago

This has been fixed and will be delivered in version 1.10.2.

pyby commented 6 years ago

Available on develop branch.