search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

tvOS compatibility #168

Closed crymscom closed 5 years ago

crymscom commented 5 years ago

Due to time limits I didn't handled tvOS as a second target but I simply adapted the project removing or changing the conflicting parts of the code.

The best thing would be to create a new target and manage code blocks using #if TARGET_OS_IOS or #if TARGET_OS_TV as you made in your tvOS branch of SRGMediaPlayer

defagos commented 5 years ago

Letterbox is now compatible with tvOS. We are waiting on TagCommander binaries for tvOS (in fact, we'll probably do the work ourselves), so no official release can be made yet. But everything else is ready on our side.

As already discussed elsewhere, we will be in touch when you feel ready to integrate our tvOS-compatible Letterbox in RSI for Apple TV. I would recommend waiting for an official release, though. I am quite optimistic one will be made before the end of the year, but we'll keep you informed.

I'll close this PR, as it is now of no real use anymore. Thanks for initiating this Apple TV-stuff in the first place!

pyby commented 4 years ago

Thank you for your PR. It was an help to push this feature at the top of our backlog.

We just delivered the 2.0.0 release, with an official tvOS support.

We recommend to use this new release, and give us any feedback.