search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

Zoom mode and font sizes does not impact text and button for controls #173

Open SebastienChauvin opened 5 years ago

SebastienChauvin commented 5 years ago

Issue type

Incorrect behavior

Description of the problem

Use selects large font size and zoom mode (as described here: https://www.imore.com/how-use-zoom-accessibility-iphone-and-ipad )

Environment information

Reproducibility

Always reproducible

Code sample

Steps to reproduce

  1. Select large fonts
  2. Select Zoom mode
  3. See that player button and texts have the same size. They are now very small compared to the rest of the iOS / Application
SebastienChauvin commented 5 years ago

IMG_0558

SebastienChauvin commented 5 years ago

https://github.com/SRGSSR/srg-media-player-android-play/issues/259

defagos commented 4 years ago

At the moment this is desired behavior I would say. We use font sizes automatically aligned with system settings where appropriate, not everywhere. We also do in the player, just not for all labels. What is important is that text stays readable, not that font sizes balloon everywhere. In your screenshot, I would say that the elapsed time label is readable enough and does not need size adjustments, so I would not change anything.