search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

AirPlay button does not disappear when disabling service integration #201

Closed defagos closed 4 years ago

defagos commented 4 years ago

When disabling service integration, a visible AirPlay button does not get hidden anymore. This issue is probably related to a 2.0.0 change for audio / video icon display. Be very careful, this code is tricky because of the buggy behavior of AirPlay in general (most notably when already enabled from the control center).

Issue type

Incorrect behavior

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Open the standalone demo
  2. Enable AirPlay services, the icon should appear
  3. Disable AirPlay services, the icon does not disappear
defagos commented 4 years ago

Fixed by commit 58191e34992a204889a3de6d0b36fb01b637053a of SRG Media Player. This commit has no associated risk since it does not change any visibility condition, merely observes AirPlay setting changes better.

I am considering an improvement to the AirPlay button visibility condition itself. I think it should probably not be hidden in general. We can namely always send the audio of a video to an AirPlay receiver, even when external playback is not allowed (in which case displaying the AirPlay audio icon is better). This behavior has been implemented on the feature/airplay-button-visibility branch of SRG Media Player for further discussion.

defagos commented 4 years ago

The new visibility behavior has been approved, will be reviews and made available in SRG Media Player 3.0.1.