defagos
commented
3 years ago The date components formatting crash occurs because the time is sometimes infinite, most notably when opening AOD content. I pushed a fix onto the feature/m1-fix branch.
The other crash is a deeper issue probably related to the toolset itself. Not sure this is something we can fix without reporting the problem to Apple directly. A sample project using layoutIfNeeded in a similar way as Letterbox should probably give us more insights.
What is unclear, though, is how these issues affect real code built for the App Store. With Letterbox demo built in debug mode and running on an M1, the layoutIfNeeded crash occurs with any kind of content, while this is not the case with Play installed from the App Store on M1. On the other hand, opening an AOD in Play crashes, like it does in Letterbox demo debugged on M1, and though this crash seems more related to an assertion.
My proposal:
- We deliver the date components formatting fix on
feature/m1-fixand a next version of Play using this version. - We check whether the Play app sill crashes in production when run on M1 and attempting to play an AOD.
If the app otherwise does not crash this means that the layout crash might be only relevant to the project being run with My Mac (Designed for iPad) as target (we cannot enable the Catalyst checkbox officially yet), in which case I would wait until we can properly build the project with Catalyst to see if some bug reporting to Apple is really required.
Catalyst support is not complete for Letterbox. At the moment Letterbox compiles and runs on M1 using My Mac (Designed for iPad) as target, though, but some crashes occur:
layoutIfNeeded.