SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

Leak in demo debug builds #246

Closed defagos closed 3 years ago

defagos commented 3 years ago

There is a strange leak in the demo, only for debug builds. We should investigate.

Issue type

Incorrect behavior

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Run a debug build on device or in the simulator.
  2. Play the SWI example.
  3. Close the player. Sound does not stop.

Interesting things to note:

defagos commented 3 years ago

The leak was created by the playlist request in the advanced controller, creating a retain cycle with the view controller and thus preventing the player from correctly being released.

I fixed the code on iOS and applied the same fix for the similar tvOS code, though I didn't observe the leak for the demo when run on this platform.

defagos commented 3 years ago

Delivered with the 7.1.0 release.