iOS / tvOS 15 compatibility

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience

https://srgssr.github.io/marketing/letterbox/

MIT License

14 stars 7 forks source link

iOS / tvOS 15 compatibility #249

Open defagos opened 3 years ago

defagos commented 3 years ago

I tested the betas and, though I didn't find any major issue, we should check that the following issues are fixed soon, otherwise we should report them to Apple:

[x] That the new tvOS 15 player layout works well (see https://github.com/SRGSSR/srgmediaplayer-apple/issues/104).
[x] That the project compiles fine (not so anymore with beta 3 because of extension unavailability of UIApplication.sharedApplication). (✅ works with beta 5)

Issues that have been found:

[ ] The new info panel buttons on tvOS are only refreshed when opening the info panel. (ℹ️: Not fixed in RC; must be reported as a bug)
[x] The Live label is not displayed. (✅ works in tvOS 15.2)

defagos commented 3 years ago

Compilation issues with SPM are a documented change and we probably have to do something, as said in the Xcode 13 beta release notes:

Linking Swift packages from application extension targets or watchOS applications no longer emits unresolvable warnings about linking to libraries not safe for use in application extensions. This means that code referencing APIs annotated as unavailable for use in app extensions must now themselves be annotated as unavailable for use in application extensions, in order to allow that code to be used in both apps and app extensions. (66928265)

Airship delivered version 14.6.0 to fix this issue.

defagos commented 3 years ago

We can also use the new related contents on tvOS 15 to display audio chapters, see WWDC session.
There is also native support for credits skipping buttons apparently.
There is also now a native Live label.
Action buttons can be added (e.g. speed button).

Also have a look at the updated documentation.

defagos commented 3 years ago

The Live label might apparently automatically be displayed. For the moment I could not see it, we can therefore keep our own label until a later beta.

defagos commented 3 years ago

Supporting chapters is a story in itself, as it requires a dedicated view controller, cells, etc. We already have a dedicated task #221.

defagos commented 2 years ago

Most of the work has been delivered in 7.2.0, but I'll leave this task open as some issues might require some radars to be created (and thus might be fixed in later iOS 15 and tvOS 15 updates).

defagos commented 2 years ago

We found a regression due to iOS 15 changes: https://github.com/SRGSSR/srgmediaplayer-apple/issues/110

defagos commented 2 years ago

The iOS 15 regressions have been fixed in SRG Media Player 6.1.5.

defagos commented 2 years ago

The Live label will appear in tvOS 15.2.