search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

AirPlay button incorrectly displayed for instances not registered with the service #264

Closed defagos closed 2 years ago

defagos commented 2 years ago

The AirPlay button should likely not be available if the controller attached to a Letterbox view is not the one registered with the Letterbox service.

This seems obvious, which explains why we should check a bit if this is intended behavior or some obvious bug we never saw. The button can be used to enable audio AirPlay (which is a use case in general), but in Letterbox this use case is probably covered well enough (and more consistently) through the control center.

Issue type

Incorrect behavior

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Open Letterbox demo.
  2. Under the Miscellaneous tab, open the standalone player SWI VOD example.
  3. The AirPlay button is visible.
defagos commented 2 years ago

Obvious fix available on feature/airplay-button-fix. Like every obvious fix, we probably should be extra careful the fixed behavior was not intended behavior.

defagos commented 2 years ago

Would revert #201. Needs to be discussed with @pyby first, but I am not sure I still agree with my old self 🙂

pyby commented 2 years ago

2022 discussion should be done again @defagos . Let's try your proposition. I agree with this approach, and Control center oriented.