search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

Superfluous zoom gestures when zooming is not possible #272

Closed defagos closed 2 years ago

defagos commented 2 years ago

When zooming is not possible (e.g. full-screen playback of a 16:9 video on an iPhone SE) then the zoom gesture should not do anything. Currently it silently toggles content gravity, which means an extra pinch out gesture is required to exit full screen mode.

Issue type

Incorrect behavior

Environment information

Reproducibility

Always reproducible

Steps to reproduce

Provide step-by-step instructions about how to reliably reproduce the issue (or if not possible, with a good probability)

  1. Comment out -letterboxViewShouldDisplayFullScreenToggleButton: in the advanced palyer demo.
  2. Run the demo and play some media.
  3. Rotate to landscape and pinch in to zoom. Nothing happens, but now you must pinch out twice to exit full screen (which is the case when setting sliders appear on top of the video in the tweaked advanced demo).
defagos commented 2 years ago

Available for review on feature/pinch-improvements.

I ensured that fill mode is not supported anymore if aspect ratios of the content / layer mismatch (up to some epsilon tolerance).

pyby commented 2 years ago

The check to fill gravity support wasn't call at good time when the controls with the timeline are animated automatically.

We iterated and decided to compare the presentation size to the Letterbox view size.