SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

iOS timeline view not interactive in some cases #274

Closed pyby closed 2 years ago

pyby commented 2 years ago

Issue type

Incorrect behavior

Description of the problem

When ending an on demand content with segments, the continuous playback screen is displayed. If the user cancels the proposition, the player view goes back to the idle view with the thumbanail and a play button. The timeline is displayed again.

Expected behavior: Timeline is displayed. user can select a segment, and scroll. Current behavior: the tap is only toggling the player controls display/hide. Only the timeline scroll has the expected behavior.

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Open a VoD with segments
  2. Seek to the end.
  3. Cancel the continuous playback proposition, if any.
  4. There is only the play button on the player view, and the timeline below. Try to tap on a timeline cell.
pyby commented 2 years ago

The issue appeared with Letterbox version 8.0.0 and the modern gestures. The gesture recognizers moved to the main SRGLetterboxView and can interact on the timeline view frame as well, which create some priorities and gesture changes.

A proposition is to move back gestures on the playbackView as did on version 7.5.0.

pyby commented 2 years ago

The view hierarchy was flat between playbackView and controls view. Putting controls view in the playbackView sub views allows to have both controls gestures and moderns gestures, which are hosted by the playbackView.

An unused view is also removed in SRGControlsView. It was the host of the previous single tap gesture for interactivity in version 7.5.0.