SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience

https://srgssr.github.io/marketing/letterbox/

MIT License

14 stars 7 forks source link

Update to Commanders Act version 5 #283

Closed defagos closed 1 year ago

defagos commented 1 year ago

As a member of the analytics team I want results to be gathered with the new Commanders Act platform requiring version 5 of the SDKs to be running in mobile applications.

Acceptance criteria

The Commanders Act SDK has been updated.
Integration documentation has been updated if needed.

Tasks

[x] Update SRG Analytics to version supporting Commanders Act version 5 (Related to https://github.com/SRGSSR/srganalytics-apple/issues/62).

defagos commented 1 year ago

Since we discussed to remove the environment flag in SRG Analytics we cannot determine the corresponding flag we were sending in diagnostics report. Shouldn't we also remove it? If not we will have to add a Letterbox controller parameter to enable prod or preproduction diagnostics, which might be a bit overkill IMHO.

Moreover I propose we remove the code used to hide any kind of video content in production builds. DRM-protected content is replaced with a black rectangle anyway, other content should not be an issue anymore. So this feature is more of an annoyance now (especially since it also prevents us from mirroring video playback with TestFlight builds).

defagos commented 1 year ago

Question for @StaehliJ and @amtins: Do you agree we could remove the environment field we send to Snitch in diagnostics reports (see previous message)?

@pyby and I agree this is a good idea since this value has probably been never used anyway.

amtins commented 1 year ago

@defagos I am not against deleting this field, even if we use it from time to time. However, we should not forget to update the specification PerformanceReport.js#L59-L101