360° playback possible improvements

SRGSSR / srgmediaplayer-apple

An advanced media player library, simple and reliable

MIT License

158 stars 33 forks source link

360° playback possible improvements #39

Closed defagos closed 5 years ago

defagos commented 6 years ago

We now support 360 video playback directly in SRG Media Player. There are still a few ideas which could be implemented:

Limit motions to +pi/2 and -pi/2 when moving up and down.
Disable pan gesture with cardboard and re-center.
Add inertia to pan gestures.
Implement camera reset to face the content.
Have camera orientation stable under device rotation.

None of those have been discussed or are mandatory, I just wanted to keep track of what could be possible if we want to go further.

vpdn commented 6 years ago

Cool, is 360 Videos already part of the current LB release? Would love to update to test out. Also would like to see whether this might interfere with our "pull down to dismiss" gesture recognizer.

defagos commented 6 years ago

Moreover, there are a few issues on iOS 9, due to issues with SKVideoNode:

360° playback automatically starts, even if the media was only prepared. See for example the following post.
SKVideoNode leaks. See for example the following github issue.

These problems have been fixed with iOS 10. I mitigated the second issue since it can be quite annoying (playback is paused, but the leaks is not removed).I recommend we do not lose time fixing these issues further, though.

defagos commented 6 years ago

@vpdn This is part of the next LB release.

defagos commented 6 years ago

Note that currently:

Playback is paused when switching between normal and cardboard 360° playback. This is due to SKVideoNode being deallocated. Currently we let things as is, since this could make sense after all. If we get complaints we'll try to improve such transitions.
Until iOS 11, Split Over on an iPad stops the video frame (but not the playback itself) for 360° playback. This is not the case anymore with iOS 11: As for normal videos, playback continues. For the moment we won't write code to deal with this minor inconsistency, which will after all disappear when iOS 11 is the minimum version we support.

defagos commented 5 years ago

360° has been in use in our apps for quite some time and the improvements I suggested do not seem necessary at the moment.