playerDestructionBlock fix

[tooolbox]

Fixes #46

This is more of a suggestion than anything; I didn't touch your tests.

Thanks for the great library! 😄

[tooolbox]

Hm, there's definitely some points I don't understand about the code, as well. In my app, the creation & destruction blocks are called each time I play a video, but the code looks like it should only call the creation block if there's no previous player, and only call the destruction block if there's no new player. Neither of which make sense...

Anyway, just commenting on that because I might have gotten some aspects of this PR wrong, but for sure the mediaPlayer's player is nil by the time the destruction block is called, so this is my attempt to handle that.

[pyby]

Hi @tooolbox ,

Thank you for your sharing code.

• On your latest commit, you moved the playerDestructionBlock to be called each time the setPlayer: is called.

• When playing a new URL, or stop the current media, the AVPlayer is released. So you'll have a new playerCreationBlock call in many cases, like playing a new URL or stopand play the same URL.

We'll come back to you about #46.

[tooolbox]

• On your first point there, the destruction block should be called each time setPlayer: is called, right? A new player is created and assigned every time you start a video playing, so I think the destruction block should be called each time, right?
• Okay, thanks for the clarification.

[defagos]

Thanks for your PR. The documentation was clearly incorrect.

Your PR correctly fixes the code so that it matches the documentation. I pushed an additional commit to improve the player lifecycle documentation, which was not clear enough about the fact that the creation and destruction blocks can be called several times over the course of the controller lifetime, as @pyby said. I also updated the tests to take into account the new block parameter.

What could still be discussed is whether the destruction block must be called right before destruction, or after destruction has occurred. I would say that, for the time being, having the destruction block called before the creation block (in the case of a URL switch, for example) is better, most notably if you perform AVAudioSession changes.

We'll discuss the PR with @pyby and merge it accordingly. Thanks for your help!

[pyby]

Thank you @tooolbox for the PR. 🎉

[tooolbox]

Absolutely guys, glad to help. Thank you!