search

SRGSSR / srgmediaplayer-apple

An advanced media player library, simple and reliable
MIT License
158 stars 33 forks source link

Subtitle selection is not immediately updated when casting via AirPlay #59

Closed defagos closed 5 years ago

defagos commented 5 years ago
  1. Enable AirPlay.
  2. Change subtitles for the advanced Apple stream.
  3. The selection is not updated. Tapping again fixes the issue.
defagos commented 5 years ago

Automatic subtitle selection is a device-dependent concept (its behavior can be altered by device and content languages, as well as accessibility settings).

For this reason, the automatic settings of an AirPlay receiver and of an iOS device can lead to different subtitle tracks be selected, and are therefore not the same. We cannot therefore have the iOS device perfectly mirror the setting of an AirPlay receiver (i.e. say Automatic in the tracks popover if the Apple receiver is set to Automatic), but merely reflect which track is being used (if any), or if no subtitles are displayed. This can be the result of the user having chosen an explicit language on the receiver, disabled subtitles, or set the receiver to Automatic.

For this reason, when using AirPlay, the Automatic entry is now disabled: result

defagos commented 5 years ago

The fix is available on the feature/tracks-sync branch for review.