SRGSSR / srgmediaplayer-apple

An advanced media player library, simple and reliable
MIT License
158 stars 33 forks source link

Player sometimes stays stuck in the stalled state #88

Closed defagos closed 3 years ago

defagos commented 4 years ago

When playing videos mostly, sometimes the player stays in the stalled state at start. The media plays, but the state is stalled (with the advanced player demo, you can see that the loading indicator spins indefinitely).

When this happens, inducing a player state transition (e.g. pause / play or seek) fixes the issue, but this is of course not a solution.

defagos commented 4 years ago

I have a fix proposal on feature/stall-detection-fix. I think that playbackIsLikelyToKeepUp is not always correctly triggered, and I propose a more self-contained implementation which relies only on playback states.

I propose we check the logic together and test this issue for a while (as this is difficult to simulate or write as a UT).

pyby commented 4 years ago

To test in Play SRG nightlies. your branch is now on develop and in SRGSSR/playsrg-ios.