search

SRI-CSL / SMT.tmbundle

Linguist/TextMate support for SMT-LIB2
The Unlicense
7 stars 2 forks source link

Hashtag symbol (#) in function names breaks syntax highlighting #1

Open aterga opened 5 years ago

aterga commented 5 years ago

Hi, and thank you for developing this VS Code extension.

I've noticed that the following breaks the highlighting: 

(set-info :category "industrial")
(declare-sort |T@U| 0)
(declare-sort |T@T| 0)
(declare-fun Ctor (T@T) Int)
(declare-fun intType () T@T)
(declare-fun int_2_U (Int) T@U)
(declare-fun U_2_int (T@U) Int)
(declare-fun type (T@U) T@T)
(declare-fun LitInt (Int) Int)
(declare-fun BoxType () T@T)
(declare-fun $Box (T@U) T@U)
(declare-fun MapType (T@T T@T) T@T)
(declare-fun MapTypeInv0 (T@T) T@T)
(declare-fun MapTypeInv1 (T@T) T@T)
(declare-fun |Set#Card| (T@U) Int) ; <-------------------- broken after this line
(declare-fun |Map#Card| (T@U) Int)
(declare-fun |Map#Values| (T@U) T@U)
(declare-fun |Map#Empty| (T@T T@T) T@U)
(declare-fun |Map#Build| (T@U T@U T@U) T@U)
ianamason commented 5 years ago

Thanks @WirelessWizard for reporting this. I will try and fix it once I page it all back in.

nunoplopes commented 4 years ago

I bumped into this one today as well with the following:

(declare-fun |@foo_i8#i8!void#ub!9| () Bool)
ianamason commented 4 years ago

Either of you guys are welcome to fix it, I had a quick look and didn't succeed.

nunoplopes commented 4 years ago

This line here seems to be missing the # char: https://github.com/SRI-CSL/SMT.tmbundle/blob/master/Syntaxes/smt.tmLanguage#L116

I just have no clue how to test a grammar change in VS Code ☺

ianamason commented 4 years ago

I did five years ago, it was a bit of an adventure, and I had time. But a lot has happened in 5 years and I fear it has been permanently paged out. I can add it and hold my breath. Though I think I would need to push it upstream to the linguist repository. Alas I am very busy so ...

ianamason commented 4 years ago

But if you feel the urge, I can certainly pass the buck to you. You could be chief maintainer of the SMT.bundle. There would be no turning back. Your life would be forever changed. Fame, fortune, celebrity status ...