search

SRI-CSL / whole-program-llvm

A toolkit for building whole-program LLVM bitcode files
MIT License
72 stars 11 forks source link

bzip2 make all fail #26

Closed aaltinay closed 5 years ago

aaltinay commented 5 years ago

Line 37 of Makefile in bzip2, clang should be gclang I think. It fails otherwise.

ianamason commented 5 years ago

There is a patch no?

aaltinay commented 5 years ago

Looks like I open the issue to wllvm instead of gllvm, my bad :D The patch looks like to replace CC. This is for the other Makefile: src/github.com/SRI-CSL/gllvm/examples/bzip2/Makefile

ianamason commented 5 years ago

Ok I will take a look tomorrow.

ianamason commented 5 years ago

No that just the linking step on the produced bitcode. It can be clang or clang++ with no issues.

aaltinay commented 5 years ago

Yes but if clang is not on the $PATH, it will not find clang. That was the case for me. I am not really familiar with the project but we set environment variables like LLVM_COMPILER or LLVM_COMPILER_PATH to tell gllvm/wllvm where is the compiler and I believe gllvm/wllvm uses these env variables to find the right compiler. So I changed clang to gllvm and it fixed compilation error.

ianamason commented 5 years ago

Yes I suppose that’s true. You’ll excuse me if I don’t let perfect be the enemy of good.

ianamason commented 5 years ago

Fixed by this over at gllvm