search

SRI-CSL / yices2

The Yices SMT Solver
https://yices.csl.sri.com/
GNU General Public License v3.0
370 stars 47 forks source link

windows ci -- checking build and test-api on pull requests #465

Closed ahmed-irfan closed 1 year ago

coveralls commented 1 year ago

Coverage Status

coverage: 65.097% (-0.001%) from 65.098% when pulling 36180f22fdca43b37f3a25a6d565ef9ccd44282d on win-ci-2 into f2a53c5cce2e1393eff0aab0860ed91542b406ad on master.

markpmitchell commented 1 year ago

Looks good to me. Why is the final test "make check-api" as opposed to "make check"? Are the regression tests too slow?

ahmed-irfan commented 1 year ago

Looks good to me. Why is the final test "make check-api" as opposed to "make check"? Are the regression tests too slow?

Some tests are failing because of printing mismatch under windows. This needs further investigation and may take come time. In the meantime, I wanted to add the window compilation check in CI.

And yes, the windows CI (including running the tests) is too slow. That's why I didn't enable for each commit push -- it is enabled for pull requests.

markpmitchell commented 1 year ago

Makes sense!--Mark MitchellOn Oct 7, 2023, at 9:13 PM, Ahmed @.***> wrote:

Looks good to me. Why is the final test "make check-api" as opposed to "make check"? Are the regression tests too slow?

Some tests are failing because of printing mismatch under windows. This needs further investigation and may take come time. In the meantime, I wanted to add the window compilation check in CI. And yes, the windows CI (including running the tests) is too slow. That's why I didn't enable for each commit push -- it is enabled for pull requests.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>