Fix successful submissions not being removed from cache

[JordanHoang]

• [ ] Fix issue where on successful save of trap visit form submissions, we are removing it from the current trapVisitSubmissions array
• [ ] should also be logic to ensure if some trap visit submissions are successful, while others aren't, then we remove successful ones, while leaving the failed ones

so I’m seeing where in the other placesin the code where we have a fullfilled.type the logic we are doing is monitoring program

      state.submissionStatus = 'submission-successful'
      state.previousMonitoringProgramSubmissions = [
        ...state.previousMonitoringProgramSubmissions,
        ...monitoringProgramPostResult,
      ]
      state.monitoringProgramSubmissions = []

mark recapture

      const markRecapturePostResult = action.payload.markRecaptureResponse
      const markRecaptureReleaseCrewPostResult =
        action.payload.markRecaptureReleaseCrewResponse
      const markRecaptureReleaseMarksPostResult =
        action.payload.markRecaptureReleaseMarksResponse

      state.submissionStatus = 'submission-successful'
      state.previousMarkRecaptureSubmissions = [
        ...state.previousMarkRecaptureSubmissions,
        ...markRecapturePostResult,
      ]
      state.markRecaptureSubmissions = []

      state.previousMarkRecaptureReleaseCrewSubmissions = [
        ...state.previousMarkRecaptureReleaseCrewSubmissions,
        ...markRecaptureReleaseCrewPostResult,
      ]
      state.markRecaptureReleaseCrewSubmissions = []

      state.previousMarkRecaptureReleaseMarksSubmissions = [
        ...state.previousMarkRecaptureReleaseMarksSubmissions,
        ...markRecaptureReleaseMarksPostResult,
      ]
      state.markRecaptureReleaseMarksSubmissions = []

      console.log('successful mark Recap post processing: ', action.payload)

but in trap visit, not doing anything

    [postTrapVisitFormSubmissions.fulfilled.type]: (state, action) => {
      state.submissionStatus = 'submission-successful'
      console.log('successful post processing: ', action.payload)
    },

[JordanHoang]

look into this comment:

We did have logic there But for whatever reason, looks like I removed logic there during this commit