SRJPE / rst-pilot-app-client

Rotary Screw Trap Data Collection application
0 stars 0 forks source link

Feather& Yuba requests bug fixes and new features, turbidity & validation trigger updates #314

Closed bpintel closed 6 months ago

bpintel commented 6 months ago

Completes #275, #267, #277 & #304.

Hunner4D commented 6 months ago

These are great changes! Did catch one error when inputting to flow measure on trap operations Screenshot 2024-03-25 at 1 58 00 PM And noticed that trap and catch are being submitted more times than on dev

bpintel commented 6 months ago

These are great changes! Did catch one error when inputting to flow measure on trap operations Screenshot 2024-03-25 at 1 58 00 PM And noticed that trap and catch are being submitted more times than on dev

Thanks Hunter, I just added an extra condition to the edge case in useFlowMeasureCalculationBool What number of submissions are you getting on dev? I have:

Typing that out I just noticed the number of submissions is incrementing by 1. This might be a clue to what is causing this.

JordanHoang commented 6 months ago

These are great changes! Did catch one error when inputting to flow measure on trap operations Screenshot 2024-03-25 at 1 58 00 PM And noticed that trap and catch are being submitted more times than on dev

Thanks Hunter, I just added an extra condition to the edge case in useFlowMeasureCalculationBool What number of submissions are you getting on dev? I have:

  • TrapVisit: 1
  • TrapOps: 2
  • FishProcess: 3
  • FishIput: 4
  • TrapPostProcessing: 5

Typing that out I just noticed the number of submissions is incrementing by 1. This might be a clue to what is causing this.

blocker or good to merge?