search

SRL / SRL-5

SRL 5
https://villavu.com
GNU General Public License v3.0
32 stars 34 forks source link

Removed unused variable #105

Closed SRL-Nebula closed 12 years ago

SRLJustin commented 12 years ago

Hi Neb.

Please have a look at this: https://github.com/SRL/SRL-5/pull/98

Justin.

ghost commented 12 years ago

Like Coh3n said in #98, removing things like this might break compatibility and should thus be removed in a greater update that renews larger parts of SRL. SRL-5 stands as one example; the next would be SRL-6 On Oct 29, 2012 9:13 AM, "Justin" notifications@github.com wrote:

Hi Neb.

Please have a look at this: SRL/SRL-5#98https://github.com/SRL/SRL-5/issues/98

Justin.

— Reply to this email directly or view it on GitHubhttps://github.com/SRL/SRL-5/pull/105#issuecomment-9858748.

SRLJustin commented 12 years ago

Should we make a null function in the include that would use the variable to remove this warning/hint?

Sent from my iPhone

On 29/10/2012, at 7:21 PM, Axel Selmer-Anderssen notifications@github.com wrote:

Like Coh3n said in #98, removing things like this might break compatibility and should thus be removed in a greater update that renews larger parts of SRL. SRL-5 stands as one example; the next would be SRL-6 On Oct 29, 2012 9:13 AM, "Justin" notifications@github.com wrote:

Hi Neb.

Please have a look at this: SRL/SRL-5#98https://github.com/SRL/SRL-5/issues/98

Justin.

— Reply to this email directly or view it on GitHubhttps://github.com/SRL/SRL-5/pull/105#issuecomment-9858748.

— Reply to this email directly or view it on GitHub.

cohenadair commented 12 years ago

I would be okay with that.

ghost commented 12 years ago

I don't see the point, but I guess it doesn't matter that much.. name it something like __unusedVariables so that people can see that it shouldn't be called in scripts and only in SetupSRL;

cohenadair commented 12 years ago

The only real point would be that it get's rid of the unused variable warning. Only reason I say I'm okay with it is so people stop making pull requests for it (I think this is the second or third).

SRL-Nebula commented 12 years ago

Sorry I didn't check the closed requests first :/