search

SRL / SRL-5

SRL 5
https://villavu.com
GNU General Public License v3.0
32 stars 34 forks source link

Basic Action Bar Functions #114

Closed euphemism closed 11 years ago

euphemism commented 11 years ago

Added 'IsActionBarOpen' and 'ToggleActionBar' to 'gametab.simba'

riwu commented 11 years ago

For the IsActionBarOpen, there is a chance that one end of it gets block by option menu: http://villavu.com/forum/showpost.php?p=1130143&postcount=16

Maybe change the Boolean modifier 'and' to 'or'? But that may result in false positive so CountColor for more pixels instead?

For ToggleActionBar, should it also return true, if it is successfully toggled off? I didn't model mine after ToggleXPBarEx though, quite surprise that we ended up something so similar :p https://github.com/SRL/SRL-5/pull/113/files

euphemism commented 11 years ago

There is not a single place you can check that can't be covered up by a option box. It checks for two red pixels, one in each of the small rectangles at either end of the bar. At any rate, I can change the condition to 'or'. Yes, I have it returning true if it successfully toggles the bar, so on or off.

riwu commented 11 years ago

Yeah that's what i was saying, but there could be a minute chance that an object on the main screen has the same color at the same coordinate, unlikely though.

You are right about the result, guess i was doing an unnecessary double negative :(

cohenadair commented 11 years ago

Merged manually.