SRM-IST-KTR / githubsrmv2

https://githubsrmist.tech

GNU General Public License v3.0

3 stars 5 forks source link

Centre footer in mobile View #88

Closed djdiptayan1 closed 3 weeks ago

djdiptayan1 commented 1 month ago

The footer content needs to be centered and justified. the social buttons and "Created By GCSRM Team 🐐" needs to be centered. Also center the logo and adderss

Sameer01-01 commented 1 month ago

I can fix this issue.

before

Screenshot 2024-10-23 120842

After

Screenshot 2024-10-23 120911

djdiptayan1 commented 1 month ago

Sure. text in discord. team lead will assign it to you @Sameer01-01

UtkarshJaiswal1406 commented 1 month ago

@Sameer01-01 keep in mind that its still off center from the page's perspective because the 'scroll to top' button is messing with the alignment on the right side. also that white line at the bottom shouldnt be there. Keep these issues in mind while working on this

Sameer01-01 commented 1 month ago

Sure. text in discord. team lead will assign it to you @Sameer01-01

ok..should i text in the technical discussion channel or somewhere else??

UtkarshJaiswal1406 commented 1 month ago

ok..should i text in the technical discussion channel or somewhere else??

technical discussion

Sameer01-01 commented 1 month ago

@Sameer01-01 keep in mind that its still off center from the page's perspective because the 'scroll to top' button is messing with the alignment on the right side. also that white line at the bottom shouldnt be there. Keep these issues in mind while working on this

ok bhiaya...the white line is just visible in chrome when i view it in different phones using chrome dev tools, it won't be there in the deployed website.

the scroll button is fixed in the webpage...should i move the footer a little upwards so that it will be centered and also it wont look odd with respect to the scroll button??

UtkarshJaiswal1406 commented 1 month ago

ok bhiaya...the white line is just visible in chrome when i view it in different phones using chrome dev tools, it won't be there in the deployed website.

the scroll button is fixed in the webpage...should i move the footer a little upwards so that it will be centered and also it wont look odd with respect to the scroll button??

scroll button is messing with the horizontal alignment. I don't see how moving the footer up would help. Try something else

UtkarshJaiswal1406 commented 1 month ago

I'm assigning this issue to you. Create a new branch and experiment

Add me, diptayan and anushka as the reviewers whenever your decide to open a PR

Sameer01-01 commented 1 month ago

I'm assigning this issue to you. Create a new branch and experiment

ok bhaiya..i will do that.

Sameer01-01 commented 1 month ago

i have done a change...the scroll button will be visible till contact us form and after that it will be hidden...by doing this the footer will be centered...is this ok??