search

SReject / JSON-For-Mirc

JSON parser for mIRC
20 stars 6 forks source link

Duplicate $comerr identifier in this line #29

Closed westor7 closed 7 years ago

westor7 commented 7 years ago

I saw that you have duplicate calling the $comerr identifier into this line, i am not sure that this is nessesary into this line.

Check: https://github.com/SReject/JSON-For-Mirc/blob/master/src/JSON%20For%20mIRC.mrc#L1581

SReject commented 7 years ago

This is intentional, each $comerr is a check to the previous $com call. Its similar to doing it like:

if ($com(SReject/JSONForMirc/JSONShell, Error, 2, dispatch* SReject/JSONForMirc/JSONShellError) && !$comerr) {
    if ($com(SReject/JSONForMirc/JSONShellError) && $com(SReject/JSONForMirc/JSONShellError, Description, 2) && !$comerr) {
        if ($com(SReject/JSONForMirc/JSONShellError).result !== $null) {
            %Error = $v1
        }
    }
}