Add logic to use different FindPackage for python if cmake is above 3.12

SRombauts / SQLiteCpp

SQLiteC++ (SQLiteCpp) is a smart and easy to use C++ SQLite3 wrapper.

http://srombauts.github.io/SQLiteCpp

MIT License

2.19k stars 509 forks source link

Add logic to use different FindPackage for python if cmake is above 3.12 #454

Closed syntheticgio closed 3 weeks ago

syntheticgio commented 10 months ago

find_package(PythonInterp) has been deprecated since cmake 3.5 and is throwing a warning as of 3.27 (maybe earlier). Since the minimum required version is 3.5 for this repo, added a branch to use the appropriate find_package depending on the version.

Tested with 3.27 (above the split) and 3.10.x (below the split). Both were successful for me (ubuntu:18.04 & 22.04).

SRombauts commented 4 weeks ago

Hello, for whatever reason I am not able to see this warning in the logs from CI or in my own Windows environment with the latest CMake. Any idea on what I am missing? Anything specific on how you call CMake? edit: I could now reproduce the issue, I am going to merge this PR

SRombauts commented 3 weeks ago

Thank you for your contribution. Sébastien