search

SRombauts / SQLiteCpp

SQLiteC++ (SQLiteCpp) is a smart and easy to use C++ SQLite3 wrapper.
http://srombauts.github.io/SQLiteCpp
MIT License
2.22k stars 510 forks source link

cmake build warning: `cmake --help-policy CMP0148` #472

Open dvtate opened 3 months ago

dvtate commented 3 months ago

cmake gives the following build warning:

CMake Warning (dev) at third_party/SQLiteCpp/CMakeLists.txt:390 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.
UnixY2K commented 3 months ago

this is due to: CMP0148 I think it could be replaced by FindPython3,

probably something like this should be enough to remove the warning and be backwards compatible:

if(CMAKE_VERSION VERSION_LESS "3.27") 
    #the code that uses findpython3
else()
    #the old code
endif()

I think that python was used in the cmake build for linting or running unit tests

UnixY2K commented 1 month ago

454 fixed this