search

SRombauts / UEGitPlugin

Unreal Engine 5 Git LFS 2 Source Control Plugin (beta)
http://srombauts.github.io/UEGitPlugin
MIT License
811 stars 165 forks source link

Verbose logging enabled in RunCommandInternalRaw #106

Open ccarvalheiro opened 5 years ago

ccarvalheiro commented 5 years ago

In a recent commit, the logging in RunCommandInternalRaw was enabled by commenting #if UE_BUILD_DEBUG. See here and here.

Was this change made intentionally? It appears to slows down our mid sized projects and (Disregard this since it shouldn't have any significant impact on performance) Sometimes floods the log making it difficult to use.

SRombauts commented 4 years ago

Yes, it's intentional since I received bug reports when I have only the logs to try to understand what's going on.

Sorry for the inconvenience, the idea would be to add a setting to have this optional.

ccarvalheiro commented 4 years ago

Oh, that makes sense. I can help with that. Should we add a checkbox to the source control dialog or hide it away in project settings (in the plugin settings category)?

SRombauts commented 4 years ago

Hello, until now I have always put everything on the source control dialog.

Perhaps should we also be able to find some of these settings also in the project settings? I never thought about it but I am pretty sure it would help people find them.

Cheers!