SRombauts / UEGitPlugin

Unreal Engine 5 Git LFS 2 Source Control Plugin (beta)
http://srombauts.github.io/UEGitPlugin
MIT License
806 stars 165 forks source link

Unable to build the plugin. "FApp is not a class or namespace name" #117

Closed stephan-nordnes-eriksen closed 4 years ago

stephan-nordnes-eriksen commented 4 years ago

When downloading the newest version from releases tab, (2.13-beta), and I copy that to my plugins folder, unreal asks me to rebuild the plugin. When I press yes, it starts to build, but fails with the message "MyProject could not be compiled. Try rebuilding from source manually"

Looking at the log when building I see the current errors showing up:

C:\myProject\Pluigns\UE4GitPlugin\Source\GitSourceControl\Private\SGitSourceControlSettings.cpp(50): error C2653: 'FApp': is not a class or namespace name
C:\myProject\Pluigns\UE4GitPlugin\Source\GitSourceControl\Private\SGitSourceControlSettings.cpp(50): error C3861 'GetProjectName': identifier not found

I have tried a bunch of things, like updating my Visual Studio dependencies, verifying unreal engine etc. Tried building on another computer as well, but same results.

Running on version 4.23.1 of Unreal Engine on windows 10

Is there something I am missing, or could this be a bug?

SRombauts commented 4 years ago

Hello, I'll have to have a look at the release since you should not have to rebuild the plugin! About missing FApp, it's even weirder but I might be able to reproduce it if it's relative to the first problem above

varthshenon commented 4 years ago

I'm getting the mssage as well "... could not be compiled. Try rebuilding from source manually"

Running on version 4.23.1 of Unreal Engine on Mac (Mojave)

SRombauts commented 4 years ago

Sorry but I have just tried it one more time, using UE4.23.1 binary from the Unreal Launcher and a source zip download from my latest 2.13-beta release (unzipped in a new Plugins folder in my project) and it's working like a charm for me.

Tested with a fresh new third person BP project. Would you be able to retest with such a test project?

Anything else that I might be missing?

varthshenon commented 4 years ago

Tried on blank Third Person BP Project. Still getting the same message

Screen Shot 2019-11-18 at 14 14 38
SRombauts commented 4 years ago

Okay, I think there are two different problems here:

  1. @stephan-nordnes-eriksen did probably not pick the last release for Windows, so the Engine ask him to rebuild the plugin, which never happens with an official release for which I provided Binaries for Win64
  2. @varthshenon is on Mac, so in this case it is normal that you have to rebuild
  3. The rebuild itself should not fail (I just forced a rebuild on my template project and it went fine)

=> for the rebuild issue I will see what include is missing, since the most obvious problem in my opinion is a "non unity build" issue where includes are missing but not causing issue for "unity builds"

SRombauts commented 4 years ago

Adding bFasterWithoutUnity = true; to UE4GitPlugin\Source\GitSourceControl\GitSourceControl.Build.cs enabled me to reproduce and fix the compilation issue.

Thanks for reporting this.

Cheers!

stephan-nordnes-eriksen commented 4 years ago

@SRombauts I will try your suggestion as soon as possible. I have some other pressing matters to take care of first. I will keep you posted.

Regarding your feedback. I am pretty sure I downloaded the correct release for windows, but just in case, could you link to it so that I am sure I am not messing it up?

SRombauts commented 4 years ago

I meant, downloading the "source code" zip or gzip from https://github.com/SRombauts/UE4GitPlugin/releases/tag/2.13-beta (that is, the archive https://github.com/SRombauts/UE4GitPlugin/archive/2.13-beta.zip for instance)

stephan-nordnes-eriksen commented 4 years ago

I got it to work now!

The problem was that I work on a project with more people, and someone else had opened the project with 4.22 which caused problems. Resetting the "engine version", and getting a clean download of the plugin worked. I did not have to rebuild the binaries! :) Ps. I used 2.14-beta.

Thanks for the help!

SRombauts commented 4 years ago

Good, thanks for the update.