Out memory error 4.25 with DX12 RHI

duplexsystem commented 4 years ago

Withe the latest version form source control I get an out of video memory error when trying to save. I have 11gb of video memory and the project is 1gb so there is no conceivable way it could run out. (don't know why it would even be using VRAM)

Carbon-NateBowman commented 4 years ago

To add some info to this issue.

Issue is easily reproducible by me and my team when checking out any asset config/texture/level etc with RHI set to DirectX12.

It only occurs for me and my team when using dx12, past dx11 projects work fine.

After opening a working existing dx11 project, switching RHI to DX12, and restarting the editor, the issue occurs upon first checkout.

The issue occurs with release 2.16-beta and still occurs after https://github.com/SRombauts/UE4GitPlugin/commit/214af6df6adbd133f616b6191b090012cafb7f3c

@SRombauts I cannot find a workaround for this, and as my team rely on an LFS locking workflow we are a bit stuck until it is resolved.

duplexsystem commented 4 years ago

@Carbon-NateBowman after getting this with another plugin I determined it was a UE 4.25 bug. You can attempt to verify this is you want. But I do no know if it can be fixed plugin side or has to be fixed engine side.

SRombauts commented 4 years ago

Thanks for reporting this and updating me. The question is, is this happening without Source Control enabled ?

Carbon-NateBowman commented 4 years ago

Thanks for reporting this and updating me. The question is, is this happening without Source Control enabled ?

It does not appear to happen without source control enabled. For me, DX12, no source control, at least 5hrs a day since 4.25 release, not happened once.

duplexsystem commented 4 years ago

I've had it happen with the megascans plug-in (another plugin which would be doing similar UE side operations) only starting with 4.25, with dx12 which is far to specific to be unrelated.

Carbon-NateBowman commented 4 years ago

I've had it happen with the megascans plug-in (another plugin which would be doing similar UE side operations) only starting with 4.25, with dx12 which is far to specific to be unrelated.

Oh, that's a good point, when 4.25 came out, I also had that (but straight ctd, no error) when importing large megascans assets with their first 4.25 plugin versions. It was resolved after a few revisions. As a test, I just imported a few 8k surfaces and high poly models (with all lods) without issue.

Carbon-NateBowman commented 4 years ago

UE 4.24.3 with 2.15-beta RHI set to DX12, spikes on checkout but not fatal for small numbers of assets. However, checking out multiple items causes the same kind of spike and eventually a crash, just much slower.

Checking out 25 items.

duplexsystem commented 4 years ago

Which makes me think it's not a bug with update to 4.25 but a bug or change with ue that requires a plug-in side work around or change.

crevetor commented 4 years ago

I'm having the same issue :(

SRombauts commented 4 years ago

Sorry guys, I am having more things to deal with on my day job, and at the same time more things to do with the family at home. Thanks a lot @crevetor for fixing this for us all

Carbon-NateBowman commented 4 years ago

Better results in 4.25 but unfortunately not fixed completely.

see https://github.com/SRombauts/UE4GitPlugin/pull/142#issuecomment-658848702