search

SRombauts / UEGitPlugin

Unreal Engine 5 Git LFS 2 Source Control Plugin (beta)
http://srombauts.github.io/UEGitPlugin
MIT License
810 stars 165 forks source link

Updated to 4.6, added Init dialog. #15

Closed Web-eWorks closed 9 years ago

Web-eWorks commented 9 years ago

TArray<>::FindMatch is deprecated in 4.6. It is replaced by IndexOfByPredicate(). Unfortunately, I do not possess the required knowledge to make the transition, so I settled for a todo notice in the code.

Updated and compiled for UE4 4.6.0.

Web-eWorks commented 9 years ago

Added a Git Init dialog. Not quite pretty yet, but it works.

SRombauts commented 9 years ago

Thanks a lot for this, as I have no time available currently for this!

I think I have done localy the switch to the recommended find API, I'll look init it.

SRombauts commented 9 years ago

Hi @Web-eWorks,

I have updated the code with the fix for the correct Find API and tested it against 4.5 (last version I currently own)

I have also updated the README and the plugin version: can you please rebuild it for me, so that I can make a binary release for UE4.6?

Thank you again! SRombauts

Web-eWorks commented 9 years ago

Done.

SRombauts commented 9 years ago

Hi @Web-eWorks,

Just to let you know:

I have given my plugin to Epic Games for integration into the upcoming 4.7 But for re-license clarity, I have removed all the code I was not the author, so the init dialog was stripped off :(

Now you can make a similar Pull Request directly to EpicGames.

Cheers!

SRombauts commented 9 years ago

Hi,

I believe everything will be clear while UE4.7 will be out. They will explain this!

But there will be no download, it will be integrated by default into the Engine. You will only have to select it on the list of source control. Only at first it will be marked 'experimental' so there will be an option to tick on a menu.

also you will have to remove my plugin from your project to avoid a clash.

MikeFricker commented 9 years ago

I think what we're going to do actually is enable the plugin by default in 4.7, but put a "Beta!" warning right next to it in the dropdown list where you select your source control provider. We did leave the plugin marked as "Beta" as well, but thought it was more discoverable if it was enabled by default. So as of yesterday that's how we've set it up in the 4.7 branch. We'll see as we get further along with QA testing.

SRombauts commented 9 years ago

Nice! Will be easier for newcomers :)