Fixed a bug introduced with "Not at Head Revision"

SRombauts / UEGitPlugin

Unreal Engine 5 Git LFS 2 Source Control Plugin (beta)

http://srombauts.github.io/UEGitPlugin

MIT License

806 stars 165 forks source link

Fixed a bug introduced with "Not at Head Revision" #99

Closed MekuCube closed 5 years ago

MekuCube commented 5 years ago

Fixed a bug introduced with #95 "Not at Head Revision" where the status parameters were being incorrectly wiped. Sorry!

Steps to replicate:

Add a new asset
"Mark for Add" the asset (Right-click -> Source Control -> Mark for Add)
Run Source Control -> Submit to Source Control
Exit Submit to Source Control (cancel)
Notice that the status of the asset has been incorrectly removed.
Run Source Control -> Refresh and notice that the status is now there again.

SRombauts commented 5 years ago

Hey, thanks a lot @MekuCube for your contribution; I never had the time to properly test your new feature, but I am doing this right now.

Have you tried to propose this upstream to Epic Games? If not, I could do that and probably have it merge quite soon since I am the maintainer of the official Git Plugin!

I will also take your other fix #98 before making a new release.

Cheers! Sébastien

MekuCube commented 5 years ago

I would love to get these changes upstream, but I'm not super familiar with the process (these contributions are my first time on GitHub). We're using this plugin internally at our studio and we really appreciate that you're so open to accepting the pull requests

SRombauts commented 5 years ago

I've released it https://github.com/SRombauts/UE4GitPlugin/releases/tag/2.12-beta :)

I'll dig a bit more into this, see what could be improved, and open some new tasks to track these (and probably ask for help).

I'll let you know eventually.

Cheers!