Diff against Depot doesn't work if the path contains a space (1.8.1)

[Ewan-Selkirk]

After upgrading the plugin from 1.8.0 to 1.8.1 the 'Diff against Depot' function no longer works, stating that is is unable to find the revision twice.

Downgrading back to 1.8.0 fixes the issues. This is happening with Unreal Engine 5.1 not built from source.

[SRombauts]

Thanks for reporting this, and for all the details, I'll take a quick look and will let you know!

[SRombauts]

The old command was

LogSourceControl: Verbose: RunDumpToFile: 'cm cat "rev:C:/Users/sebastien.rombauts/Documents/Unreal Projects/UE52TestSpacesInPath/Content/StarterContent/Blueprints/Blueprint_CeilingLight.uasset#cs:1@UE52TestSpacesInPath@SRombautsU@cloud" --raw --file="C:/Users/sebastien.rombauts/Documents/Unreal Projects/UE52TestSpacesInPath/Saved/Diff/temp-cs1-Blueprint_CeilingLight.uasset"'

while the new one is now

[2023.07.12-12.57.43:898][578]LogSourceControl: Verbose: RunCommand: 'getfile rev:C:/Users/sebastien.rombauts/Documents/Unreal Projects/UE52TestSpacesInPath/Content/StarterContent/Blueprints/Blueprint_CeilingLight.uasset#cs:1@UE52TestSpacesInPath@SRombautsU@cloud --raw --file="C:/Users/sebastien.rombauts/Documents/Unreal Pro' (334 chars, 0 files) 

Note that we dropped for some reason the double quotes around the "RevSpec" rev:C:/xxx

[SRombauts]

So the fix in RunGetFile() is simply to change back from

    Parameters.Add(InRevSpec);

to

    Parameters.Add(FString::Printf(TEXT("\"%s\""), *InRevSpec));

[SRombauts]

Thanks again for reporting this, I fixed it. Are you able to install the dev version from the master branch, or will you require a new bugfix release @Ewan-Selkirk?

[Ewan-Selkirk]

Thank you for the quick fix! I'll give installing the plugin from the master branch a go when I get the chance

[Ewan-Selkirk]

Just got it installed and everything is working. Thanks again!