search

SRombauts / UEPlasticPlugin

Plastic SCM Plugin for Unreal Engine
http://srombauts.github.io/UEPlasticPlugin
147 stars 29 forks source link

New-style status command from 8.0.16.3000 crashes the plugin #58

Closed moppius closed 5 years ago

moppius commented 5 years ago

The PlasticSCM release for 8.0.16.3000 (release notes here) introduces a new-style format for the output from the cm status command.

This causes the RunStatus method to fail and crash due to the unexpected output when the UE4PlasticPlugin is used with version 8.0.16.3000 or newer.

moppius commented 5 years ago

We have a WIP hotfix branch here: https://github.com/EmbarkStudios/UE4PlasticPlugin/tree/hotfix/legacy-status-format - I will open a PR once we have validated everything is working (currently it no longer crashes, but checking out seems broken).

SRombauts commented 5 years ago

Hi @moppius, thanks again for you original fix.

I made a new release https://github.com/SRombauts/UE4PlasticPlugin/releases/tag/1.4.5 to fix some additional bugs that where indeed still present in 1.4.3: https://github.com/SRombauts/UE4PlasticPlugin/releases/tag/1.4.5

I remember you told me you are not using it anymore, but might be useful to be aware of this anyway.

It was also nice to meet you briefly at Unreal Fest Europe :)