Showing SECOND DOSE slot even though type 1 selected.

SRvSaha / CoWinVaccineSlotFinder

Cross-Platform Software to Fetch the Available Slots & Book the Appointment for COVID-19 Vaccination

https://shawt.io/r/sYv

MIT License

81 stars 32 forks source link

Showing SECOND DOSE slot even though type 1 selected. #76

Closed Tnu02 closed 3 years ago

Tnu02 commented 3 years ago

not sure why even thou type 1 dose is set, it showed and tried to book for SECOND DOSE ( althou it failed) but ideally it should haven't happened.

What your thoughts @SRvSaha

SRvSaha commented 3 years ago

Share the Config, it shouldn't have happened. Tried to replicate, couldn't see the bug. Do you have any screenshots?

Tnu02 commented 3 years ago

Share the Config, it shouldn't have happened. Tried to replicate, couldn't see the bug. Do you have any screenshots?

Sharing the same...

Please check @SRvSaha

2nd Dose 2nd Dose Count

Tnu02 commented 3 years ago

Also we need to take care for this execption, atleast it should not break or close the app instead it should wait for the next ip or something. Exception

SRvSaha commented 3 years ago

Also we need to take care for this execption, atleast it should not break or close the app instead it should wait for the next ip or something.

Issue Fixed. This will be a part for v5.1.0 releasing tonight

SRvSaha commented 3 years ago

Share the Config, it shouldn't have happened. Tried to replicate, couldn't see the bug. Do you have any screenshots?

Sharing the same...

Please check @SRvSaha

I think I have found the bug. Basically, it is taking correctly the vaccine available capacity of 1st Dose only but it is showing wrongly as SECOND Dose.

Just to confirm my doubt, please share the MinimumVaccineAvailability from config. Once I check that, I will be sure and it will be fixed in v5.1.0

Tnu02 commented 3 years ago

MinimumVaccineAvailability

That's correct.. @SRvSaha

MinimumVaccineAvailability was set to 2

SRvSaha commented 3 years ago

MinimumVaccineAvailability

That's correct.. @SRvSaha

MinimumVaccineAvailability was set to 2

Okay cool. My hunch was correct. Thanks for bringing this to notice. Shall be fixed and released tonight

Tnu02 commented 3 years ago

MinimumVaccineAvailability

That's correct.. @SRvSaha

MinimumVaccineAvailability was set to 2

Okay cool. My hunch was correct. Thanks for bringing this to notice. Shall be fixed and released tonight

Nice.. Looking forward to it.. Waiting.. 😊

SRvSaha commented 3 years ago

@Tnu02 v5.1.0 is now up and running! Check it out and share your feedback. Share in your circles: Windows: https://github.com/SRvSaha/CoWinVaccineSlotFinder/releases/tag/v5.1.0-windows MacOSX: https://github.com/SRvSaha/CoWinVaccineSlotFinder/releases/tag/v5.1.0-osx Linux: https://github.com/SRvSaha/CoWinVaccineSlotFinder/releases/tag/v5.1.0-linux