search

SSA-Statistical-Team-Projects / povmap

povmap: an extension to the emdi package
1 stars 5 forks source link

rgeos, maptools were archived yesterday #12

Open rsbivand opened 1 year ago

rsbivand commented 1 year ago

@davidn10 @NoraWuerz rgeos, maptools were archived yesterday, please remove them from povmap as soon as possible, as they are used unconditionally in in donttest settings.

davidn10 commented 1 year ago

Thank you, Roger, for letting us know, we will work on it.

Best, David

On Tue, Oct 17, 2023 at 9:20 AM Roger Bivand @.***> wrote:

@davidn10 https://github.com/davidn10 @NoraWuerz https://github.com/NoraWuerz rgeos, maptools were archived yesterday, please remove them from povmap as soon as possible, as they are used unconditionally in in donttest settings.

— Reply to this email directly, view it on GitHub https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE33UADEPUXW462RE3Q76ZDX72AZ5AVCNFSM6AAAAAA6D27ALOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DONBRGU2DSNA . You are receiving this because you were mentioned.Message ID: @.***>

davidn10 commented 1 year ago

Dear Roger, We have now updated the package to remove rgeos and maptools from povmap. I apologize for the delay. Do you know what the procedure is to reinstate the package on CRAN? Thank you!

Best, David

On Tue, Oct 17, 2023 at 1:20 PM David Newhouse @.***> wrote:

Thank you, Roger, for letting us know, we will work on it.

Best, David

On Tue, Oct 17, 2023 at 9:20 AM Roger Bivand @.***> wrote:

@davidn10 https://github.com/davidn10 @NoraWuerz https://github.com/NoraWuerz rgeos, maptools were archived yesterday, please remove them from povmap as soon as possible, as they are used unconditionally in in donttest settings.

— Reply to this email directly, view it on GitHub https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE33UADEPUXW462RE3Q76ZDX72AZ5AVCNFSM6AAAAAA6D27ALOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DONBRGU2DSNA . You are receiving this because you were mentioned.Message ID: @.***>

rsbivand commented 1 year ago

@davidn10 Please submit the new version online in the normal way. It will be identified as a new submission and checked more carefully than an update of a package that remained available on CRAN. So please check carefully yourself that all errors, warnings, and notes are removed (other than checking installed package size); if you can, update data to UTF-8 or explain in the submission comments why Latin-1 is needed. If you like, let me know when the code on this master branch is ready for checking, and I'll confirm your check results. CRAN also checks other aspects, so try to get the package as compliant as possible.

davidn10 commented 1 year ago

Hi Roger, Thanks for your guidance so far regarding this. We resubmitted the package about 10 days ago. Do you have any sense of how long it will take to review and post it on CRAN? Thank you!

Best, David

On Fri, Nov 3, 2023 at 3:27 PM Roger Bivand @.***> wrote:

@davidn10 https://github.com/davidn10 Please submit the new version online in the normal way. It will be identified as a new submission and checked more carefully than an update of a package that remained available on CRAN. So please check carefully yourself that all errors, warnings, and notes are removed (other than checking installed package size); if you can, update data to UTF-8 or explain in the submission comments why Latin-1 is needed. If you like, let me know when the code on this master branch is ready for checking, and I'll confirm your check results. CRAN also checks other aspects, so try to get the package as compliant as possible.

— Reply to this email directly, view it on GitHub https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12#issuecomment-1792985216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE33UAGZUHDVAD47WIU7MT3YCVASFAVCNFSM6AAAAAA6D27ALOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSHE4DKMRRGY . You are receiving this because you were mentioned.Message ID: @.***>

rsbivand commented 1 year ago

@davidn10 I think you missed emails from CRAN, to which you should have responded. In https://cran.r-project.org/incoming/archive/ I see povmap_1.0.1.tar.gz, which suggests that somethoing needed resolving but to which you did not respond. Trying to run R CMD check --as-cran on that tar archive shows:

* this is package 'povmap' version '1.0.1'
* package encoding: UTF-8
* checking CRAN incoming feasibility ... [4s/16s] NOTE
Maintainer: 'Ifeanyi Edochie <iedochie@worldbank.org>'

New submission

Package was archived on CRAN

CRAN repository db overrides:
  X-CRAN-Comment: Archived on 2023-10-31 as check problems were not
    corrected in time.

Found the following (possibly) invalid URLs:
  URL: https://cran.r-project.org/web/packages/emdi/index.html
    From: README.md
    Status: 200
    Message: OK
    CRAN URL not in canonical form
  The canonical URL of the CRAN page for a package is 
    https://CRAN.R-project.org/package=pkgname
rsbivand commented 1 year ago

This is a check log for the submitted povmap, with four notes that must be addressed: 00check.log

I'll try to suggest updates later today, but the main problem is the unresponsive nominated maintainer.

rsbivand commented 1 year ago 
Found the following (possibly) invalid URLs:
  URL: https://cran.r-project.org/web/packages/emdi/index.html
    From: README.md
    Status: 200
    Message: OK
    CRAN URL not in canonical form
  The canonical URL of the CRAN page for a package is 
    https://CRAN.R-project.org/package=pkgname

README.md should be included in .Rbuildignore, it should not be included at all.

rsbivand commented 1 year ago 
* checking installed package size ... NOTE
  installed size is  8.5Mb
  sub-directories of 1Mb or more:
    data      1.5Mb
    extdata   3.7Mb
    help      1.2Mb

The *.dta files can be compressed as zip archives, and unzipped if needed. This may still need to be explained on submission.

rsbivand commented 1 year ago 
* checking Rd cross-references ... NOTE
Package unavailable to check Rd xrefs: ‘emdi’

emdi is not listed in DESCRIPTION

rsbivand commented 1 year ago 
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
  'RtmpQaRiye\excel_output.xlsx'

No files may be left when check completes. The problem is:

R/write.excel.emdi.R:    file <- paste0(tempdir(),"\\", "excel_output.xlsx")

which hardcodes a Windows file separator, should be file <- file.path(tempdir(), "excel_output.xlsx") to run cross-platform:

> paste0(tempdir(),"\\", "excel_output.xlsx")
[1] "/tmp/RtmpqcsLA4\\excel_output.xlsx"
> file.path(tempdir(), "excel_output.xlsx")
[1] "/tmp/RtmpqcsLA4/excel_output.xlsx"
davidn10 commented 12 months ago

Dear Roger, I think we have now fixed these in the latest push. Would it be possible for you to check? Thank you very much for working with us on this!

Best, David

rsbivand commented 12 months ago

@davidn10 Check log: 00check.log

davidn10 commented 12 months ago

Dear Roger, thank you for your response. I think I have now addressed these remaining issues in the latest version. Would it be possible to check one more time? Thank you for your help!

Best, David

rsbivand commented 12 months ago

My check log using --as-cran: 00check.log

For the note on the README URL, add ^README\.md$ to .Rbuildignore. Further, you did not change line 108 in R/write.excel.emdi.R to file.path(tempdir(), "excel_output.xlsx"); this is required, as hard-wiring a Windows-specific file separator raises a note everywhere else https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12#issuecomment-1816947310.

With these changes, new check log using --as-cran: 00check.log

davidn10 commented 10 months ago

Dear Roger, Please accept my apologies for taking this long to respond, as we were on winter break. Thank you for your patience. We have now updated the repository and it passes all of the CRAN checks. There are 0 errors, 0 warnings and 6 Notes. We arenot sure if the Notes are problems, ut are also not sure how to fix them if they are. The repository is available here: https://github.com/SSA-Statistical-Team-Projects/povmap Is there anything further that needs to be done to make the repository available on CRAN?

Best regards, David

[image: image.png]

On Fri, Dec 1, 2023 at 9:04 AM Roger Bivand @.***> wrote:

My check log using --as-cran: 00check.log https://github.com/SSA-Statistical-Team-Projects/povmap/files/13526983/00check.log

For the note on the README URL, add ^README.md$ to .Rbuildignore. Further, you did not change line 108 in R/write.excel.emdi.R to file.path(tempdir(), "excel_output.xlsx"); this is required, as hard-wiring a Windows-specific file separator raises a note everywhere else #12 (comment) https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12#issuecomment-1816947310 .

With these changes, new check log using --as-cran: 00check.log https://github.com/SSA-Statistical-Team-Projects/povmap/files/13527432/00check.log

— Reply to this email directly, view it on GitHub https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12#issuecomment-1836171952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE33UADPSRWNCVK7OVL2YX3YHHPXNAVCNFSM6AAAAAA6D27ALOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZWGE3TCOJVGI . You are receiving this because you were mentioned.Message ID: @.***>

rsbivand commented 10 months ago

@davidn10 The current state of the repository yields a package for which I see no problems - the only note is related to the archiving of the package. So I think you should submit now.

davidn10 commented 10 months ago

Thank you, Roger!

Best, David

On Fri, Jan 19, 2024 at 7:48 AM Roger Bivand @.***> wrote:

@davidn10 https://github.com/davidn10 The current state of the repository yields a package for which I see no problems - the only note is related to the archiving of the package. So I think you should submit now.

— Reply to this email directly, view it on GitHub https://github.com/SSA-Statistical-Team-Projects/povmap/issues/12#issuecomment-1900354933, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE33UAFZN6AAN2DTV266UL3YPJTRBAVCNFSM6AAAAAA6D27ALOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQGM2TIOJTGM . You are receiving this because you were mentioned.Message ID: @.***>