search

SSAGESproject / SSAGES

Software Suite for Advanced General Ensemble Simulations
GNU General Public License v3.0
85 stars 29 forks source link

Build fails with gcc-11/g++-11 on MacOSX 12.3 Monterey #36

Open fgygi opened 2 years ago

fgygi commented 2 years ago

Building SSAGES-0.9.3-alpha for Qbox fails using gcc-11/g++-11 on MacOSX 12.3 Monterey. The build is using openmpi-4.1.2. The cmake command is cmake -DQBOX=yes .. -DCMAKE_C_COMPILER=gcc-11 -DCMAKE_CXX_COMPILER=g++-11 . The make command fails due to a missing #include <cstdio> in SAGES-0.9.3-alpha/include/mxx/common.hpp. 

/Users/fgygi/software/ssages/SSAGES-0.9.3-alpha/include/mxx/common.hpp:41:5: error: 'printf' was not declared in this scope
   41 |     printf("\n[Rank %d] %s:%d: %s: Assertion `%s` failed. Aborting.\n", rank, file, line, func, cond);
      |     ^~~~~~
/Users/fgygi/software/ssages/SSAGES-0.9.3-alpha/include/mxx/common.hpp:1:1: note: 'printf' is defined in header '<cstdio>'; did you forget to '#include <cstdio'?
  +++ |+#include <cstdio>
    1 | /*

Adding that #include statement fixes the issue and the build completes.

pabloferz commented 2 years ago

Fixed upstream. We always grab the master branch of mxx so this should work now. Can you confirm this @fgygi?