SSAgov / ANDI

A tool to test web content for accessibility and 508 compliance.
https://www.ssa.gov/accessibility/andi/help/howtouse.html
Other
293 stars 75 forks source link

lANDI mistakenly says elements do not have href when they do #135

Open ollie-iterators opened 2 years ago

ollie-iterators commented 2 years ago
2022-04-24_15-25-45

As seen in this image, on boston.gov, the code says that the element does not have href, id, or tabindex when href is visible on the ANDI screen.

fstrr commented 2 years ago

It is likely confused because you've used a role="group" attribute on the <a> element to change the semantics of the link. By adding role="group", you're saying that this isn't a link, it's a group. If you remove the role="group" attribute from the link then the problem goes away. If you test the page with a screenreader (I've just tried VoiceOver on macOS), you'll find that it doesn't report any of those links as links because of the group role, which you don't need.

JohnCotterSSA commented 2 years ago

Good catch, @fstrr , I was just about to comment on the role=group. Indeed, a screen reader would not recognize this element as a link.

The ANDI alert in this instance is misleading. We'll put this in the backlog.