Closed Ambient567 closed 1 year ago
Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
- [ ] You have submitted a project, that has incorrect gitflow/ Github flow. Kindly note that the gitflow of this project should have merge request flow from development into main. Your team members are supposed to give reviews to each other and merge their feature branches into the dev branch, which your submission from dev branch into main. Kindly view this article: curriculum-transversal-skills for further instructions on the same.
- [ ] Kindly also ensure that all required linter checks are showing/ correctly passing on your Pull Request
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Thank you @rloterh , my bad indeed.
In this branch I add tests to the comment counter