search

SSEKPIUS / Microverse-React-Redux-group-project---Space-Travelers-Hub

In this task, you will be working with the real live data from the SpaceX API. Your task is to build a web application for a company that provides commercial and scientific space travel services. The application will allow users to book rockets and join selected space missions.
MIT License
0 stars 0 forks source link

React & Redux group project: set up Kanban board #26

Closed SSEKPIUS closed 1 year ago

SSEKPIUS commented 1 year ago

https://github.com/SSEKPIUS/Microverse-React-Redux-group-project---Space-Travelers-Hub/projects/2 we are a group of three

Abenezer-Tilahun commented 1 year ago

Hi @SSEKPIUS @krisbobo @AhmadiGu ,

Great job so far, There are some changes that need to be implemented in order to proceed to the next project 👍

Highlights 👏🏻

✔️ Good job for Provide information about the number of people in their group

almost

Required Changes ♻️

Check the comments below the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

danmainah commented 1 year ago

Hi @team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉

Highlights

✔️ Correct info and links provided ✔️ Good design

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.